<html><head><title>PMD</title></head><body>
<center><h3>PMD report</h3></center><center><h3>Problems found</h3></center><table align="center" cellspacing="0" cellpadding="3"><tr>
<th>#</th><th>File</th><th>Line</th><th>Problem</th></tr>
<tr bgcolor="lightgrey"> 
<td align="center">1</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">15</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/coupling.html#ExcessiveImports">A high number of imports can indicate a high degree of coupling within an object.</a></td>
</tr>
<tr> 
<td align="center">2</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">74</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/codesize.html#ExcessiveClassLength">Avoid really long classes.</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">3</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">74</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/codesize.html#CyclomaticComplexity">The class 'WeaponAttackAction' has a Cyclomatic Complexity of 33 (Highest = 492).</a></td>
</tr>
<tr> 
<td align="center">4</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">114</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/typeresolution.html#LooseCoupling">Avoid using implementation types like 'ArrayList'; use the interface instead</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">5</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">114</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/typeresolution.html#LooseCoupling">Avoid using implementation types like 'ArrayList'; use the interface instead</a></td>
</tr>
<tr> 
<td align="center">6</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">142</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#MethodArgumentCouldBeFinal">Parameter 'weaponId' is not assigned and could be declared final</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">7</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">202</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/typeresolution.html#LooseCoupling">Avoid using implementation types like 'ArrayList'; use the interface instead</a></td>
</tr>
<tr> 
<td align="center">8</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">202</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/typeresolution.html#LooseCoupling">Avoid using implementation types like 'ArrayList'; use the interface instead</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">9</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">214</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#MethodArgumentCouldBeFinal">Parameter 'weaponId' is not assigned and could be declared final</a></td>
</tr>
<tr> 
<td align="center">10</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">226</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#MethodArgumentCouldBeFinal">Parameter 'ammoId' is not assigned and could be declared final</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">11</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">238</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#MethodArgumentCouldBeFinal">Parameter 'aimedLocation' is not assigned and could be declared final</a></td>
</tr>
<tr> 
<td align="center">12</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">250</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#MethodArgumentCouldBeFinal">Parameter 'aimMode' is not assigned and could be declared final</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">13</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">366</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/codesize.html#ExcessiveMethodLength">Avoid really long methods.</a></td>
</tr>
<tr> 
<td align="center">14</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">366</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/codesize.html#CyclomaticComplexity">The method 'toHit' has a Cyclomatic Complexity of 492.</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">15</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">366</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/codesize.html#NcssMethodCount">The method toHit() has an NCSS line count of 739</a></td>
</tr>
<tr> 
<td align="center">16</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">368</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#LongVariable">Avoid excessively long variable names like exchangeSwarmTarget</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">17</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">372</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'lastTarget' (lines '372'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">18</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">384</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn">A method should have only one exit point, and that should be the last statement in the method</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">19</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">392</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#LocalVariableCouldBeFinal">Local variable 'tempTarget' could be declared final</a></td>
</tr>
<tr> 
<td align="center">20</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">394</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'lastTarget' (lines '394'-'2,089').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">21</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">397</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'targetEntity' (lines '397'-'400').</a></td>
</tr>
<tr> 
<td align="center">22</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">403</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#LongVariable">Avoid excessively long variable names like isAttackerInfantry</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">23</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">403</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#LocalVariableCouldBeFinal">Local variable 'isAttackerInfantry' could be declared final</a></td>
</tr>
<tr> 
<td align="center">24</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">404</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#LocalVariableCouldBeFinal">Local variable 'isWeaponInfantry' could be declared final</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">25</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">409</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment">Assigning an Object to null is a code smell.  Consider refactoring.</a></td>
</tr>
<tr> 
<td align="center">26</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">413</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#LocalVariableCouldBeFinal">Local variable 'isIndirect' could be declared final</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">27</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">416</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/optimizations.html#LocalVariableCouldBeFinal">Local variable 'isInferno' could be declared final</a></td>
</tr>
<tr> 
<td align="center">28</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">425</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#LongVariable">Avoid excessively long variable names like isArtilleryIndirect</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">29</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">436</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'isHaywireINarced' (lines '436'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">30</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">437</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'isINarcGuided' (lines '437'-'477').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">31</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">439</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'isECMAffected' (lines '439'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">32</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">442</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#LongVariable">Avoid excessively long variable names like isTargetECMAffected</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">33</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">445</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'isHoming' (lines '445'-'521').</a></td>
</tr>
<tr> 
<td align="center">34</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">445</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'isHoming' (lines '445'-'2,089').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">35</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">447</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'bHeatSeeking' (lines '447'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">36</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">453</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'bFTL' (lines '453'-'2,089').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">37</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">459</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'bApollo' (lines '459'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">38</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">465</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'inSameBuilding' (lines '465'-'2,089').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">39</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">469</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/basic.html#CollapsibleIfStatements">These nested if statements could be combined</a></td>
</tr>
<tr> 
<td align="center">40</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">477</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'isINarcGuided' (lines '477'-'2,089').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">41</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">481</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'toSubtract' (lines '481'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">42</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">484</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'toHit' (lines '484'-'500').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">43</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">484</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'toHit' (lines '484'-'641').</a></td>
</tr>
<tr> 
<td align="center">44</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">484</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'toHit' (lines '484'-'2,089').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">45</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">485</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'reason' (lines '485'-'486').</a></td>
</tr>
<tr> 
<td align="center">46</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">494</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn">A method should have only one exit point, and that should be the last statement in the method</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">47</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">501</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn">A method should have only one exit point, and that should be the last statement in the method</a></td>
</tr>
<tr> 
<td align="center">48</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">508</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn">A method should have only one exit point, and that should be the last statement in the method</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">49</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">512</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'munition' (lines '512'-'515').</a></td>
</tr>
<tr> 
<td align="center">50</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">521</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'isHoming' (lines '521'-'2,089').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">51</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">526</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'targEl' (lines '526'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">52</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">539</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'spotter' (lines '539'-'551').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">53</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">540</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'narcSpotter' (lines '540'-'552').</a></td>
</tr>
<tr> 
<td align="center">54</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">552</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'narcSpotter' (lines '552'-'2,089').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">55</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">564</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'eistatus' (lines '564'-'587').</a></td>
</tr>
<tr> 
<td align="center">56</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">565</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'MPMelevationHack' (lines '565'-'573').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">57</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">573</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'MPMelevationHack' (lines '573'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">58</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">598</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'losMods' (lines '598'-'1,645').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">59</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">598</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'losMods' (lines '598'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">60</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">608</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn">A method should have only one exit point, and that should be the last statement in the method</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">61</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">686</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'def' (lines '686'-'706').</a></td>
</tr>
<tr> 
<td align="center">62</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">834</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'bapMod' (lines '834'-'837').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">63</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">839</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'tcMod' (lines '839'-'846').</a></td>
</tr>
<tr> 
<td align="center">64</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">869</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'eccm' (lines '869'-'872').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">65</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">973</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'onlyBarracuda' (lines '973'-'983').</a></td>
</tr>
<tr> 
<td align="center">66</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">974</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'onlyPiranha' (lines '974'-'988').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">67</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">983</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'onlyBarracuda' (lines '983'-'983').</a></td>
</tr>
<tr> 
<td align="center">68</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">988</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'onlyPiranha' (lines '988'-'988').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">69</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">988</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'onlyPiranha' (lines '988'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">70</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1067</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'aaaMod' (lines '1,067'-'1,069').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">71</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1275</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'aElev' (lines '1,275'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">72</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1276</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'tElev' (lines '1,276'-'2,089').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">73</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1277</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'distance' (lines '1,277'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">74</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1401</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#LongVariable">Avoid excessively long variable names like ammunitionToHitModifier</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">75</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1401</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'ammunitionToHitModifier' (lines '1,401'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">76</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1424</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'modifier' (lines '1,424'-'1,436').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">77</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1650</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/basic.html#CollapsibleIfStatements">These nested if statements could be combined</a></td>
</tr>
<tr> 
<td align="center">78</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1694</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'proneMod' (lines '1,694'-'1,700').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">79</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1969</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'side' (lines '1,969'-'1,987').</a></td>
</tr>
<tr> 
<td align="center">80</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1973</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'usePrior' (lines '1,973'-'1,983').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">81</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">1974</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'attackPos' (lines '1,974'-'1,980').</a></td>
</tr>
<tr> 
<td align="center">82</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2014</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/design.html#ConfusingTernary">Avoid if (x != y) ..; else ..;</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">83</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2037</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'distance' (lines '2,037'-'2,089').</a></td>
</tr>
<tr> 
<td align="center">84</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2099</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/codesize.html#ExcessiveMethodLength">Avoid really long methods.</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">85</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2099</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/codesize.html#ExcessiveParameterList">Avoid really long parameter lists.</a></td>
</tr>
<tr> 
<td align="center">86</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2099</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/codesize.html#CyclomaticComplexity">The method 'toHitIsImpossible' has a Cyclomatic Complexity of 391.</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">87</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2099</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/codesize.html#NcssMethodCount">The method toHitIsImpossible() has an NCSS line count of 457</a></td>
</tr>
<tr> 
<td align="center">88</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2108</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'isHoming' (lines '2,108'-'2,287').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">89</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2108</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'isHoming' (lines '2,108'-'3,172').</a></td>
</tr>
<tr> 
<td align="center">90</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2109</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'toHit' (lines '2,109'-'3,037').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">91</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2109</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'toHit' (lines '2,109'-'3,172').</a></td>
</tr>
<tr> 
<td align="center">92</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2136</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/basic.html#CollapsibleIfStatements">These nested if statements could be combined</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">93</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2176</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/basic.html#CollapsibleIfStatements">These nested if statements could be combined</a></td>
</tr>
<tr> 
<td align="center">94</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2264</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/basic.html#CollapsibleIfStatements">These nested if statements could be combined</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">95</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2279</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'munition' (lines '2,279'-'2,281').</a></td>
</tr>
<tr> 
<td align="center">96</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2287</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'isHoming' (lines '2,287'-'3,172').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">97</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2412</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#ShortVariable">Avoid variables with short names like js</a></td>
</tr>
<tr> 
<td align="center">98</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2422</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#ShortVariable">Avoid variables with short names like o</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">99</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2481</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'vf_cool' (lines '2,481'-'2,484').</a></td>
</tr>
<tr> 
<td align="center">100</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2484</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'vf_cool' (lines '2,484'-'3,172').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">101</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2577</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#ShortVariable">Avoid variables with short names like o</a></td>
</tr>
<tr> 
<td align="center">102</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2599</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'useable' (lines '2,599'-'2,609').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">103</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2602</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#ShortVariable">Avoid variables with short names like m</a></td>
</tr>
<tr> 
<td align="center">104</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2628</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'usedFrontArc' (lines '2,628'-'2,632').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">105</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2629</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'usedRearArc' (lines '2,629'-'2,633').</a></td>
</tr>
<tr> 
<td align="center">106</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2632</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'usedFrontArc' (lines '2,632'-'2,632').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">107</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2632</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'usedFrontArc' (lines '2,632'-'3,172').</a></td>
</tr>
<tr> 
<td align="center">108</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2633</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'usedRearArc' (lines '2,633'-'2,633').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">109</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2633</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'usedRearArc' (lines '2,633'-'3,172').</a></td>
</tr>
<tr> 
<td align="center">110</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2638</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/naming.html#ShortVariable">Avoid variables with short names like o</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">111</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2648</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'loc' (lines '2,648'-'2,648').</a></td>
</tr>
<tr> 
<td align="center">112</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2648</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'loc' (lines '2,648'-'2,677').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">113</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2649</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'rearMount' (lines '2,649'-'2,649').</a></td>
</tr>
<tr> 
<td align="center">114</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2649</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'rearMount' (lines '2,649'-'2,678').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">115</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2658</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/design.html#ConfusingTernary">Avoid if (x != y) ..; else ..;</a></td>
</tr>
<tr> 
<td align="center">116</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2679</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'currentHeat' (lines '2,679'-'2,682').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">117</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2689</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'onlyArc' (lines '2,689'-'3,172').</a></td>
</tr>
<tr> 
<td align="center">118</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2710</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/design.html#ConfusingTernary">Avoid if (x != y) ..; else ..;</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">119</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2855</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/design.html#ConfusingTernary">Avoid if (x != y) ..; else ..;</a></td>
</tr>
<tr> 
<td align="center">120</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2868</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'spotter' (lines '2,868'-'2,874').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">121</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2885</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'eistatus' (lines '2,885'-'2,906').</a></td>
</tr>
<tr> 
<td align="center">122</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">2887</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DD'-anomaly for variable 'multiPurposeelevationHack' (lines '2,887'-'2,893').</a></td>
</tr>
<tr bgcolor="lightgrey"> 
<td align="center">123</td>
<td width="*%">src/megamek/common/actions/WeaponAttackAction.java</td>
<td align="center" width="5%">3096</td>
<td width="*"><a href="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis">Found 'DU'-anomaly for variable 'distance' (lines '3,096'-'3,172').</a></td>
</tr>
</table></body></html>